Rocksolid Light

Welcome to novaBBS

register   nodelist   faq  

Your account also provides newsreader access to all groups at news.i2pn2.org port 119 or 563 (TLS)


rocksolid / Programming / Re: ok fixed

SubjectAuthor
* vichan outgoing attachments (2)Retro Guy
+* i have been working on a similar problemAnonymous
|`- Re: i have been working on a similar problemRetro Guy
+* he, that is richAnonymous
|`- Re: he, that is richRetro Guy
+- works with messages posted on def4Anonymous
+* NoneAnonymous
|`- Re: Vichan header (w/attachment)Retro Guy
+- the line beforeAnonymous
+* ok, bbs puts it in both linesAnonymous
|`* Re: ok, bbs puts it in both linesRetro Guy
| `- Re: ok, bbs puts it in both linesRetro Guy
+- ok, then it is settledAnonymous
+- yeah sureAnonymous
+* ok fixedAnonymous
|`* Re: ok fixedRetro Guy
| `* Re: ok fixedanon
|  `- Re: ok fixedRetro Guy
`* newsportal codeAnonymous
 `* Re: newsportal codeRetro Guy
  `- Re: newsportal codeRetro Guy

Pages:123
Subject: Re: ok, bbs puts it in both lines
From: Retro ...@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Organization: Rocksolid Light
Date: Thu, 11 Jun 2020 10:53 UTC
Path: i2pn2.org!.POSTED!not-for-mail
From: Retro Guy@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Subject: Re: ok, bbs puts it in both lines
Date: Thu, 11 Jun 2020 10:53 UTC
Organization: Rocksolid Light
Message-ID: <2e74c68a146b1edddf88774a3ddd20a1$1@www.novabbs.com>
References: <536716545ac3003ada9b38182d31871b$1@www.novabbs.com> <code.266.2ala9u@anon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org; posting-account="retrobbs1";
logging-data="2136"; mail-complaints-to="usenet@i2pn2.org"
User-Agent: Rocksolid Light (news.novabbs.com/getrslight)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on novabbs.com
X-Rslight-Site: $2y$10$Wrn3erSTF5BhT/65MzUKfu8k8EmhaMu0sU4crOYTr4uCqZ1fMW2Lu
Xref: rslight2 rocksolid.programming:73
Message-ID: <2e74c68a146b1edddf88774a3ddd20a1$1@www.novabbs.com>
Anonymous wrote:

see the relevant part of the header here (posted on def4):

Content-Type: image/jpeg;
 name="test.jpg"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="test.jpg"

i can do the same with vichan, i guess. not sure if there is a right or a wrong way here (would have to read the rfc again :-) ), but this might be the fastest way.

I've only tried to view in rslight and knode (kde newsreader), and neither displays a name unless it's in the Content-Type: header. So it's not just rslight, at least knode also. Both (rslight and knode) react the same way to the message.

Retro Guy

--
Posted on: Rocksolid Light
www.novabbs.com


Subject: ok, then it is settled
From: pos...@anon.com (Anonymous)
Newsgroups: rocksolid.programming
Organization: def5
Date: Thu, 11 Jun 2020 11:04 UTC
Path: i2pn2.org!i2pn.org!rocksolid2!def5!.POSTED.bogusentry!not-for-mail
From: Anonymous <poster@anon.com>
Newsgroups: rocksolid.programming
Subject: ok, then it is settled
Date: Thu, 11 Jun 2020 04:04:17 -0700
Organization: def5
Message-ID: <code.268.3u18yy@anon.com>
References: <536716545ac3003ada9b38182d31871b$1@www.novabbs.com>
Content-Type: text/plain; charset=UTF-8
Injection-Info: def5.org; posting-host="bogusentry:192.168.1.189";
logging-data="13537"; mail-complaints-to="usenet@def5.org"
Xref: rslight2 rocksolid.programming:74
Message-ID: <code.268.3u18yy@anon.com>
i will change the vichan code for the posting.
have to do that anyway on the receiving end as well, handling attachments well is one of the harder parts.
glad that you solved the inline attachments problem.

cheers

trw

--
Posted on def2


Subject: Re: ok, bbs puts it in both lines
From: Retro ...@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Organization: Rocksolid Light
Date: Thu, 11 Jun 2020 11:12 UTC
Path: i2pn2.org!.POSTED!not-for-mail
From: Retro Guy@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Subject: Re: ok, bbs puts it in both lines
Date: Thu, 11 Jun 2020 11:12 UTC
Organization: Rocksolid Light
Message-ID: <844738e02a86cbb4b5e5f0416fd5c7b6$1@www.novabbs.com>
References: <536716545ac3003ada9b38182d31871b$1@www.novabbs.com> <code.266.2ala9u@anon.com> <2e74c68a146b1edddf88774a3ddd20a1$1@www.novabbs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org; posting-account="retrobbs1";
logging-data="5209"; mail-complaints-to="usenet@i2pn2.org"
User-Agent: Rocksolid Light (news.novabbs.com/getrslight)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on novabbs.com
X-Spam-Level: *
X-Rslight-Site: $2y$10$xwSAFya//rXvwtqTtigl6uLpHOAKI5/HlAL3zk0TfMQdKSHxlP9ii
Xref: rslight2 rocksolid.programming:75
Message-ID: <844738e02a86cbb4b5e5f0416fd5c7b6$1@www.novabbs.com>
Retro Guy wrote:

Anonymous wrote:

see the relevant part of the header here (posted on def4):

Content-Type: image/jpeg;
 name="test.jpg"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="test.jpg"

i can do the same with vichan, i guess. not sure if there is a right or a wrong way here (would have to read the rfc again :-) ), but this might be the fastest way.

I've only tried to view in rslight and knode (kde newsreader), and neither displays a name unless it's in the Content-Type: header. So it's not just rslight, at least knode also. Both (rslight and knode) react the same way to the message.

I read this:

In 1996 RFC2045 re-defined the Content-Type header but this time there was no explicit “name” parameter mentioned. In 1997 RFC2183 fixed this by adding a new header Content-Disposition that has a parameter called filename, suitable for, as the name suggests, defining attachment filenames.

So apparently the name was moved from one header to another. This can cause new and old software to react differently. From what I see, having it in both places does not conflict with the RFC (it doesn't say 'NO'), and will work in more clients. My view would be to have it in both headers if you are willing.

Retro Guy



--
Posted on: Rocksolid Light
www.novabbs.com


Subject: yeah sure
From: pos...@anon.com (Anonymous)
Newsgroups: rocksolid.programming
Organization: Rocksolid Light
Date: Thu, 11 Jun 2020 11:22 UTC
Path: i2pn2.org!.POSTED!not-for-mail
From: Anonymous <poster@anon.com>
Newsgroups: rocksolid.programming
Subject: yeah sure
Date: Thu, 11 Jun 2020 04:22:37 -0700
Organization: Rocksolid Light
Message-ID: <code.270.1i6w34@anon.com>
References: <536716545ac3003ada9b38182d31871b$1@www.novabbs.com>
Content-Type: text/plain; charset=UTF-8
Injection-Info: i2pn2.org; posting-account="retrobbs1";
logging-data="6408"; mail-complaints-to="usenet@i2pn2.org"
Xref: rslight2 rocksolid.programming:76
Message-ID: <code.270.1i6w34@anon.com>
My view would be to have it in both headers if you are willing.

you are preachin' to the choir. and i was convinced even before you quoted the RFC. :-)

--
Posted on def2


Subject: ok fixed
From: pos...@anon.com (Anonymous)
Newsgroups: rocksolid.programming
Organization: def5
Date: Sat, 13 Jun 2020 13:00 UTC
Path: i2pn2.org!i2pn.org!rocksolid2!def5!.POSTED.bogusentry!not-for-mail
From: Anonymous <poster@anon.com>
Newsgroups: rocksolid.programming
Subject: ok fixed
Date: Sat, 13 Jun 2020 06:00:30 -0700
Organization: def5
Message-ID: <code.278.2ngefm@anon.com>
References: <536716545ac3003ada9b38182d31871b$1@www.novabbs.com>
Content-Type: text/plain; charset=UTF-8
Injection-Info: def5.org; posting-host="bogusentry:192.168.1.189";
logging-data="28970"; mail-complaints-to="usenet@def5.org"
Xref: rslight2 rocksolid.programming:84
Message-ID: <code.278.2ngefm@anon.com>
the attachments name shows up now on rslight.

cheers

trw

--
Posted on def2


Subject: Re: ok fixed
From: Retro ...@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Organization: Rocksolid Light
Date: Sat, 13 Jun 2020 22:06 UTC
Path: i2pn2.org!.POSTED!not-for-mail
From: Retro Guy@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Subject: Re: ok fixed
Date: Sat, 13 Jun 2020 22:06 UTC
Organization: Rocksolid Light
Message-ID: <a8bd8c6f0d015a6076badaa14d372912$1@www.novabbs.com>
References: <536716545ac3003ada9b38182d31871b$1@www.novabbs.com> <code.278.2ngefm@anon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org; posting-account="retrobbs1";
logging-data="7903"; mail-complaints-to="usenet@i2pn2.org"
User-Agent: Rocksolid Light (news.novabbs.com/getrslight)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on novabbs.com
X-Rslight-Site: $2y$10$h3u5ANNSTqRIEh4o7sq3zegxDHdgorjUUJPqpbXet4r7TI7.UQ9m6
Xref: rslight2 rocksolid.programming:85
Message-ID: <a8bd8c6f0d015a6076badaa14d372912$1@www.novabbs.com>
Anonymous wrote:

the attachments name shows up now on rslight.

Looks good, just saw the test message.

There is still a minor issue that I'm not sure is really an issue, but I'd like to change (improve) it. It's the same on rslight, so not vichan specific:

Once an inline attachment is reached, the attachment is handled, but no text after that attachment is displayed. It stops at that point. That's why you see no footer on posts with inline attachments.

I know how to fix this, I just haven't had time to work on it yet.

Retro Guy



--
Posted on: Rocksolid Light
www.novabbs.com


Subject: Re: ok fixed
From: ano...@anon.com (anon)
Newsgroups: rocksolid.programming
Organization: def5
Date: Sun, 14 Jun 2020 01:30 UTC
Path: i2pn2.org!rocksolid2!def5!POSTED.localhost!not-for-mail
From: anon <anon@anon.com>
Newsgroups: rocksolid.programming
Message-ID: <ec24cc9c6093a7e99fcba59125205eec@def4>
Subject: Re: ok fixed
Date: Sun, 14 Jun 2020 01:30:59+0000
Organization: def5
In-Reply-To: <a8bd8c6f0d015a6076badaa14d372912$1@www.novabbs.com>
References: <a8bd8c6f0d015a6076badaa14d372912$1@www.novabbs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Xref: rslight2 rocksolid.programming:87
Message-ID: <ec24cc9c6093a7e99fcba59125205eec@def4>

Once an inline attachment is reached, the attachment is handled, but no text after that attachment is displayed.

I guess that is handled in message_parse, then ?
Happy bug hunting. :-)

cheers

trw

ps: inline attachments are a pest, and if i would have the time i would fix this in fudforum. since i don't, good to know you are on it.

Posted on def4


Subject: Re: ok fixed
From: Retro ...@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Organization: Rocksolid Light
Date: Sun, 14 Jun 2020 06:22 UTC
Path: i2pn2.org!.POSTED!not-for-mail
From: Retro Guy@rslight.i2p (Retro Guy)
Newsgroups: rocksolid.programming
Subject: Re: ok fixed
Date: Sun, 14 Jun 2020 06:22 UTC
Organization: Rocksolid Light
Message-ID: <12d3324b1b06037192122d6c94d9f7fd$1@www.novabbs.com>
References: <a8bd8c6f0d015a6076badaa14d372912$1@www.novabbs.com> <ec24cc9c6093a7e99fcba59125205eec@def4>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org; posting-account="retrobbs1";
logging-data="29711"; mail-complaints-to="usenet@i2pn2.org"
User-Agent: Rocksolid Light (news.novabbs.com/getrslight)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on novabbs.com
X-Rslight-Site: $2y$10$wwCBVcqolF20akKbeBbhiuRudA6RIJvTeLH55K2lgJwAmiUo9bu5.
Xref: rslight2 rocksolid.programming:88
Message-ID: <12d3324b1b06037192122d6c94d9f7fd$1@www.novabbs.com>
anon wrote:


Once an inline attachment is reached, the attachment is handled, but no text after that attachment is displayed.

I guess that is handled in message_parse, then ?

Yes, that's the place. I just tested my mods and it seems to be working fine. It was working before, but it's better now. It will display text after an attachment, and also not think it has an attachment if it does not (it checks that something is really there).

Originally, there was a bug in newsportal that if it saw a line in a post that started with 'begin', it would just loop forever looking for 'end'. I'm assuming the author just hadn't finished testing. This would cause rslight to timeout on such messages, so I just disabled the code.

Now I have replaced the code, and check for this stuff. I've tried to break it (I'm sure there are ways to do that ;) but it seems fairly stable now.

I suggest you try it out on rslight.i2p to see if you are happy with it before merging it into your code. I'll put 'message.inc.php.txt' in the download area in a few minutes.

ps: inline attachments are a pest, and if i would have the time i would fix this in fudforum. since i don't, good to know you are on it.

I don't miss fudforum, lol :)

Retro Guy

--
Posted on: Rocksolid Light
www.novabbs.com


Subject: newsportal code
From: pos...@anon.com (Anonymous)
Newsgroups: rocksolid.programming
Organization: i2pn2 (i2pn.org)
Date: Sun, 14 Jun 2020 11:29 UTC
Path: i2pn2.org!.POSTED!not-for-mail
From: Anonymous <poster@anon.com>
Newsgroups: rocksolid.programming
Subject: newsportal code
Date: Sun, 14 Jun 2020 04:29:44 -0700
Organization: i2pn2 (i2pn.org)
Message-ID: <code.430.1t4lmb@anon.com>
References: <536716545ac3003ada9b38182d31871b$1@www.novabbs.com>
Content-Type: text/plain; charset=UTF-8
Injection-Info: i2pn2.org; posting-account="def2";
logging-data="6902"; mail-complaints-to="usenet@i2pn2.org"
Xref: rslight2 rocksolid.programming:90
Message-ID: <code.430.1t4lmb@anon.com>
and also not think it has an attachment if it does not (it checks that something is really there).

this caused the sync routine for vichan to hang on several messages (older ones from /ts), where there was a mime attachment announced, but then wasn't there.

Originally, there was a bug in newsportal that if it saw a line in a post that started with 'begin', it would just loop forever looking for 'end'.

This did not cause any problems for me yet, it is just that the inline content is displayed as text.

it will take me a while to try out your new code.

cheers

trw

--
Posted on def2


Subject: Re: newsportal code
From: retro....@retrobbs.rocksolidbbs.com.remove-3rr-this (Retro Guy)
Newsgroups: rocksolid.programming
Organization: RetroBBS
Date: Mon, 15 Jun 2020 08:54 UTC
Path: i2pn2.org!rocksolid3!.POSTED.localhost!not-for-mail
From: "Retro Guy" <retro.guy@retrobbs.rocksolidbbs.com.remove-3rr-this>
Newsgroups: rocksolid.programming
Subject: Re: newsportal code
Date: Mon, 15 Jun 2020 08:54:08 +0000
Organization: RetroBBS
Message-ID: <25b145458efe010770c0f0dba6b171ee$1@www.rocksolidbbs.com>
References: <code.430.1t4lmb@anon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: rocksolidbbs.com; posting-host="localhost:127.0.0.1";
logging-data="22306"; mail-complaints-to="usenet@rocksolidbbs.com"
User-Agent: Rocksolid Light (news.novabbs.com/getrslight)
To: Anonymous
X-Comment-To: Anonymous
In-Reply-To: <code.430.1t4lmb@anon.com>
X-FTN-PID: Synchronet 3.17a-Linux Dec 29 2018 GCC 6.3.0
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on rocksolidbbs.com
X-Rslight-Site: $2y$10$XDniV8sEBOY4nLsmMvQnS.yoW8APENj5Hg7rqzw.G9dui.d.k8y7q
X-Gateway: retrobbs.rocksolidbbs.com [Synchronet 3.17a-Linux NewsLink 1.110]
Xref: rslight2 rocksolid.programming:92
Message-ID: <25b145458efe010770c0f0dba6b171ee$1@www.rocksolidbbs.com>
  To: Anonymous
Anonymous wrote:

and also not think it has an attachment if it does not (it checks that something is really there).

this caused the sync routine for vichan to hang on several messages (older ones from /ts), where there was a mime attachment announced, but then wasn't there.

This hopefully is solved in the latest file. You can see in rslight when an attachment is announced, but doesn't really exist (it says 'Attachments: (text/plain)', but nothing to click on. Once I finished the mod, this isn't happening as no attachment is announced.

Retro Guy

--
Posted on: RetroBBS
www.rocksolidbbs.com



Pages:123
rocksolid light 0.6.6
clearnet i2p tor